Merged
Conversation
…lding Add tests verifying system transaction hashes are properly indexed and lookable via eth_getTransactionByHash. Extend existing RPC tests to cover blocks containing both alloy and host Transact system transactions. Remove leftover debugging helpers (dbg!, dump_index_state, verbose debug panics) from active investigation. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Member
Author
|
tests written during bug review. seems valuable to simply include them |
Fraser999
approved these changes
Feb 12, 2026
Contributor
Fraser999
left a comment
Fraser999
left a comment
There was a problem hiding this comment.
One non-blocking comment.
Comment on lines
+226
to
+232
| // Two logs: one from the host transact, one from the alloy tx | ||
| assert_eq!(logs.len(), 2); | ||
| let log_inner = &logs[0].inner; | ||
| assert_eq!(log_inner.address, *contract.address()); | ||
| // First increment is from the host transact (system tx runs first) | ||
| assert_eq!(log_inner.topics(), &[Counter::Count::SIGNATURE_HASH, B256::with_last_byte(1)]); | ||
| // Second increment is from the alloy tx |
Contributor
There was a problem hiding this comment.
According to claude:
Suggested change
| // Two logs: one from the host transact, one from the alloy tx | |
| assert_eq!(logs.len(), 2); | |
| let log_inner = &logs[0].inner; | |
| assert_eq!(log_inner.address, *contract.address()); | |
| // First increment is from the host transact (system tx runs first) | |
| assert_eq!(log_inner.topics(), &[Counter::Count::SIGNATURE_HASH, B256::with_last_byte(1)]); | |
| // Second increment is from the alloy tx | |
| // Two logs: one from the alloy tx, one from the host transact | |
| assert_eq!(logs.len(), 2); | |
| let log_inner = &logs[0].inner; | |
| assert_eq!(log_inner.address, *contract.address()); | |
| // First increment is from the alloy tx (regular txs execute before system txs) | |
| assert_eq!(log_inner.topics(), &[Counter::Count::SIGNATURE_HASH, B256::with_last_byte(1)]); | |
| // Second increment is from the host transact (system tx) |
prestwich
added a commit
that referenced
this pull request
Feb 12, 2026
Regular txs execute before system txs, not the other way around. Drive-by from #74 (comment) Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
test_transaction_hash_indexingunit test tosignet-dbverifying transaction hashes are correctly written to theTransactionHashNumbersindextest_system_tx_hash_consistencyintegration test verifying system tx hashes survive consecutive block processing and are lookable via RPCtest_stateful_rpc_callsto cover blocks containing both alloy and host Transact system transactionsstart_ru_block/start_host_blockconvenience methods toSignetTestContextdbg!,dump_index_state, verbose debug panics, stale comments)Test plan
cargo clippy -p signet-db --all-features --all-targetspassescargo clippy -p signet-node-tests --all-features --all-targetspassescargo +nightly fmtcleancargo t -p signet-db— all 6 tests pass (3 unit + 3 integration)#[ignore]by default — manual run optional🤖 Generated with Claude Code